Merge branch 'develop'

Fixes after code linters suggestions
Added go vet, staticheck and lint to .drone.yml
2021-11-08 00:57:56 +01:00 · 2021-08-03 00:13:14 +02:00 · 2021-08-02 23:44:25 +02:00 · 2021-07-25 20:10:28 +01:00 · 2021-07-23 17:01:05 +02:00
17 changed files with 218 additions and 154 deletions
--- a/.drone.yml
+++ b/.drone.yml
@ -3,7 +3,32 @@ type: docker
 name: default

 steps:
- name: test
-  image: golang
+- name: static_check
+  image: golang:1.16
  commands:
-  - ls -lah
+  - go get honnef.co/go/tools/cmd/staticcheck
+  - staticcheck ./pkg/...
+  volumes:
+  - name: gopath
+    path: /go
+
+- name: lint
+  image: golang:1.16
+  commands:
+  - go get golang.org/x/lint/golint
+  - golint -set_exit_status ./pkg/...
+  volumes:
+  - name: gopath
+    path: /go
+
+- name: vet
+  image: golang:1.16
+  commands:
+  - go vet ./pkg/...
+  volumes:
+  - name: gopath
+    path: /go
+
+volumes:
+- name: gopath
+  temp: {}
--- a/go.sum
+++ b/go.sum
@ -2,6 +2,7 @@ github.com/andybalholm/brotli v1.0.2/go.mod h1:loMXtMfwqflxFJPmdbJO0a3KNoPuLBgiu
 github.com/andybalholm/brotli v1.0.3 h1:fpcw+r1N1h0Poc1F/pHbW40cUm/lMEQslZtCkBQ0UnM=
 github.com/andybalholm/brotli v1.0.3/go.mod h1:fO7iG3H7G2nSZ7m0zPUDn85XEX2GTukHGRSepvi9Eig=
 github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
+github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWoS4=
 github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
 github.com/go-redis/redis v6.15.9+incompatible h1:K0pv1D7EQUjfyoMql+r/jZqCLizCGKFlFgcHWWmHQjg=
 github.com/go-redis/redis v6.15.9+incompatible/go.mod h1:NAIEuMOZ/fxfXJIrKDQDz8wamY7mA7PouImQ2Jvg6kA=
@ -11,22 +12,27 @@ github.com/golang/protobuf v1.4.0-rc.1.0.20200221234624-67d41d38c208/go.mod h1:x
 github.com/golang/protobuf v1.4.0-rc.2/go.mod h1:LlEzMj4AhA7rCAGe4KMBDvJI+AwstrUpVNzEA03Pprs=
 github.com/golang/protobuf v1.4.0-rc.4.0.20200313231945-b860323f09d0/go.mod h1:WU3c8KckQ9AFe+yFwt9sWVRKCVIyN9cPHBJSNnbL67w=
 github.com/golang/protobuf v1.4.0/go.mod h1:jodUvKwWbYaEsadDk5Fwe5c77LiNKVO9IDvqG2KuDX0=
+github.com/golang/protobuf v1.4.2 h1:+Z5KGCizgyZCbGh1KZqA0fcLLkwbsjIzS4aV2v7wJX0=
 github.com/golang/protobuf v1.4.2/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI=
 github.com/golang/snappy v0.0.3/go.mod h1:/XxbfmMg8lxefKM7IXC3fBNl/7bRcc72aCRzEWrmP2Q=
 github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
 github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
 github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
+github.com/google/go-cmp v0.5.6 h1:BKbKCqvP6I+rmFHt06ZmyQtvB8xAkWdhFyr0ZUNZcxQ=
 github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
 github.com/klauspost/compress v1.12.2/go.mod h1:8dP1Hq4DHOhN9w426knH3Rhby4rFm6D8eO+e+Dq5Gzg=
 github.com/klauspost/compress v1.13.1 h1:wXr2uRxZTJXHLly6qhJabee5JqIhTRoLBhDOA74hDEQ=
 github.com/klauspost/compress v1.13.1/go.mod h1:8dP1Hq4DHOhN9w426knH3Rhby4rFm6D8eO+e+Dq5Gzg=
+github.com/nxadm/tail v1.4.4 h1:DQuhQpB1tVlglWS2hLQ5OV6B5r8aGxSrPc5Qo6uTN78=
 github.com/nxadm/tail v1.4.4/go.mod h1:kenIhsEOeOJmVchQTgglprH7qJGnHDVpk1VPCcaMI8A=
 github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE=
 github.com/onsi/ginkgo v1.12.1/go.mod h1:zj2OWP4+oCPe1qIXoGWkgMRwljMUYCdkwsT2108oapk=
+github.com/onsi/ginkgo v1.15.0 h1:1V1NfVQR87RtWAgp1lv9JZJ5Jap+XFGKPi00andXGi4=
 github.com/onsi/ginkgo v1.15.0/go.mod h1:hF8qUzuuC8DJGygJH3726JnCZX4MYbRB8yFfISqnKUg=
 github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY=
 github.com/onsi/gomega v1.10.1/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo=
+github.com/onsi/gomega v1.10.5 h1:7n6FEkpFmfCoo2t+YYqXH0evK+a9ICQz0xcAy9dYcaQ=
 github.com/onsi/gomega v1.10.5/go.mod h1:gza4q3jKQJijlu05nKWRCW/GavJumGt8aNRxWg7mt48=
 github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6KllzawFIhcdPw=
 github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
@ -46,6 +52,7 @@ golang.org/x/net v0.0.0-20200520004742-59133d7f0dd7/go.mod h1:qpuaurCH72eLCgpAm/
 golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
 golang.org/x/net v0.0.0-20201202161906-c7110b5ffcbb/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
 golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
+golang.org/x/net v0.0.0-20210510120150-4163338589ed h1:p9UgmWI9wKpfYmgaV/IZKGdXc5qEK45tDwwwDyjS26I=
 golang.org/x/net v0.0.0-20210510120150-4163338589ed/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
 golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
@ -62,10 +69,12 @@ golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/sys v0.0.0-20210112080510-489259a85091/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210514084401-e8d321eab015/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c h1:F1jZWGFhYfh0Ci55sIpILtKKK8p3i2/krTr0H1rg74I=
 golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
+golang.org/x/text v0.3.6 h1:aRYxNxv6iGQlyVaZmk6ZgYEDa+Jg18DxebPSrd6bg1M=
 golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
@ -73,16 +82,21 @@ golang.org/x/tools v0.0.0-20201224043029-2b0845dc783e/go.mod h1:emZCQorbCU4vsT4f
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
+golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
 golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
 google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=
 google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM=
 google.golang.org/protobuf v1.20.1-0.20200309200217-e05f789c0967/go.mod h1:A+miEFZTKqfCUM6K7xSMQL9OKL/b6hQv+e19PK+JZNE=
 google.golang.org/protobuf v1.21.0/go.mod h1:47Nbq4nVaFHyn7ilMalzfO3qCViNmqZ2kzikPIcrTAo=
+google.golang.org/protobuf v1.23.0 h1:4MY060fB1DLGMB/7MBTLnwQUY6+F09GEiz6SsrNqyzM=
 google.golang.org/protobuf v1.23.0/go.mod h1:EGpADcykh3NcUnDUJcl1+ZksZNG86OlYog2l/sGQquU=
+gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/fsnotify.v1 v1.4.7/go.mod h1:Tz8NjZHkW78fSQdbUxIjBTcgA1z1m8ZHf0WmKUhAMys=
+gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=
 gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWDmTeBkI65Dw0HsyUHuEVlX15mw=
 gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
 gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
--- a/pkg/cache/cache.go
+++ b/pkg/cache/cache.go
@ -15,14 +15,24 @@ import (
 )

 const (
-	TYPE_REDIS  = "redis"
-	TYPE_MEMORY = "memory"
+	typeRedis  = "redis"
+	typeMemory = "memory"
 )

-func GetCacheDatastore(config config.Cache) *CacheDatastore {
-	var datastore CacheDatastore
+// Datastore interface
+type Datastore interface {
+	SetKey(string, interface{}, int) error

-	if config.Type == TYPE_REDIS {
+	GetKey(string) (interface{}, error)
+
+	IsConnected() bool
+}
+
+// GetCacheDatastore function
+func GetCacheDatastore(config config.Cache) *Datastore {
+	var datastore Datastore
+
+	if config.Type == typeRedis {
 		datastore = NewRedisDatastore(config.Host, config.Port)
 	} else {
 		datastore = NewMemoryDatastore()
--- a/pkg/cache/datastore.go
+++ b/pkg/cache/datastore.go
@ -1,18 +0,0 @@
-//           ___   ____               ___       ___
-// \ \  / / | _   |  __| \ \  / / || | __  || || _ |
-//  \ \/ /  |___  | |__   \ \/ /  || |___  || ||___|
-//   \  /   | _   | _  |   \  /   ||  __ | || ||\\
-//    \/    |___  |___ |    \/    || ____| || || \\
-//
-// Copyright (c) 2021 Piotr Biernat. https://pbiernat.dev. MIT License
-// Repo: https://git.pbiernat.dev/golang/vegvisir
-
-package cache
-
-type CacheDatastore interface {
-	SetKey(string, interface{}, int) error
-
-	GetKey(string) (interface{}, error)
-
-	IsConnected() bool
-}
--- a/pkg/cache/memory_datastore.go
+++ b/pkg/cache/memory_datastore.go
@ -14,26 +14,30 @@ import (
 	"time"
 )

-type TtlItem struct {
+// TTLItem struct
+type TTLItem struct {
 	ts  int // timestamp
 	ttl int // ttl in seconds
 }

+// NewMemoryDatastore function
 func NewMemoryDatastore() *MemoryDatastore {
 	return &MemoryDatastore{
 		cache: make(map[string]interface{}),
-		ts:    make(map[string]TtlItem),
+		ts:    make(map[string]TTLItem),
 	}
 }

+// MemoryDatastore struct
 type MemoryDatastore struct {
 	cache map[string]interface{}
-	ts    map[string]TtlItem
+	ts    map[string]TTLItem
 }

+// SetKey function
 func (ds *MemoryDatastore) SetKey(key string, data interface{}, ttl int) error {
 	ds.cache[key] = data
-	ds.ts[key] = TtlItem{
+	ds.ts[key] = TTLItem{
 		ts:  time.Now().Second(),
 		ttl: ttl,
 	}
@ -41,6 +45,7 @@ func (ds *MemoryDatastore) SetKey(key string, data interface{}, ttl int) error {
 	return nil
 }

+// GetKey function
 func (ds *MemoryDatastore) GetKey(key string) (interface{}, error) {
 	ds.gc(key) // remove key is time of creation is outdated

@ -51,6 +56,7 @@ func (ds *MemoryDatastore) GetKey(key string) (interface{}, error) {
 	return nil, errors.New("Key not found" + key)
 }

+// IsConnected function
 func (ds *MemoryDatastore) IsConnected() bool {
 	return true
 }
--- a/pkg/cache/redis_datastore.go
+++ b/pkg/cache/redis_datastore.go
@ -16,6 +16,7 @@ import (
 	"github.com/go-redis/redis"
 )

+// NewRedisDatastore function
 func NewRedisDatastore(host string, port int) *RedisDatastore {
 	return &RedisDatastore{
 		client: redis.NewClient(&redis.Options{
@ -26,10 +27,12 @@ func NewRedisDatastore(host string, port int) *RedisDatastore {
 	}
 }

+// RedisDatastore class
 type RedisDatastore struct {
 	client *redis.Client
 }

+// SetKey function
 func (ds *RedisDatastore) SetKey(key string, data interface{}, ttl int) error {
 	err := ds.client.Set(key, data, time.Duration(ttl)*time.Second).Err()
 	if err != nil {
@ -39,6 +42,7 @@ func (ds *RedisDatastore) SetKey(key string, data interface{}, ttl int) error {
 	return nil
 }

+// GetKey function
 func (ds *RedisDatastore) GetKey(key string) (interface{}, error) {
 	data, err := ds.client.Get(key).Result()
 	if err != nil {
@ -48,6 +52,7 @@ func (ds *RedisDatastore) GetKey(key string) (interface{}, error) {
 	return data, nil
 }

+// IsConnected function
 func (ds *RedisDatastore) IsConnected() bool {
 	_, err := ds.client.Ping().Result()

--- a/pkg/cache/response.go
+++ b/pkg/cache/response.go
@ -14,21 +14,25 @@ import (
 	"log"
 )

+// Headers type
 type Headers map[string]string

+// ResponseCache struct
 type ResponseCache struct {
 	URL     string
 	Body    string
 	Headers Headers
 }

+// ResponseCacheManager class
 type ResponseCacheManager struct {
-	datastore CacheDatastore
+	datastore Datastore
 	prefix    string
 	ttl       int
 }

-func NewResponseCacheManager(datastore CacheDatastore, ttl int) ResponseCacheManager {
+// NewResponseCacheManager function
+func NewResponseCacheManager(datastore Datastore, ttl int) ResponseCacheManager {
 	return ResponseCacheManager{
 		datastore: datastore,
 		prefix:    "response_",
@ -36,6 +40,7 @@ func NewResponseCacheManager(datastore CacheDatastore, ttl int) ResponseCacheMan
 	}
 }

+// Save function
 func (rm *ResponseCacheManager) Save(name string, r ResponseCache) bool {
 	if !rm.datastore.IsConnected() {
 		log.Println("Response-cache:", "Not connected to server")
@ -58,6 +63,7 @@ func (rm *ResponseCacheManager) Save(name string, r ResponseCache) bool {
 	return true
 }

+// Load function
 func (rm *ResponseCacheManager) Load(name string) (bool, *ResponseCache) {
 	if !rm.datastore.IsConnected() {
 		log.Println("Response-cache:", "Not connected to server")
--- a/pkg/cache/route.go
+++ b/pkg/cache/route.go
@ -14,18 +14,21 @@ import (
 	"log"
 )

+// RouteCache struct
 type RouteCache struct {
-	SourceUrl string
-	TargetUrl string
+	SourceURL string
+	TargetURL string
 }

+// RouteCacheManager class
 type RouteCacheManager struct {
-	datastore CacheDatastore
+	datastore Datastore
 	prefix    string
 	ttl       int
 }

-func NewRouteCacheManager(datastore CacheDatastore, ttl int) RouteCacheManager {
+// NewRouteCacheManager function
+func NewRouteCacheManager(datastore Datastore, ttl int) RouteCacheManager {
 	return RouteCacheManager{
 		datastore: datastore,
 		prefix:    "route_",
@ -33,6 +36,7 @@ func NewRouteCacheManager(datastore CacheDatastore, ttl int) RouteCacheManager {
 	}
 }

+// Save function
 func (rm *RouteCacheManager) Save(name string, r RouteCache) bool {
 	if !rm.datastore.IsConnected() {
 		log.Println("Route-cache:", "Not connected to server")
@ -55,6 +59,7 @@ func (rm *RouteCacheManager) Save(name string, r RouteCache) bool {
 	return true
 }

+// Load function
 func (rm *RouteCacheManager) Load(name string) (bool, *RouteCache) {
 	if !rm.datastore.IsConnected() {
 		log.Println("Route-cache:", "Not connected to server")
--- a/pkg/client/http.go
+++ b/pkg/client/http.go
@ -8,3 +8,19 @@
 // Repo: https://git.pbiernat.dev/golang/vegvisir

 package client
+
+import "github.com/valyala/fasthttp"
+
+// HTTPClient struct
+type HTTPClient struct {
+	context *fasthttp.RequestCtx
+}
+
+// NewHTTPClient function
+func NewHTTPClient(ctx *fasthttp.RequestCtx) *HTTPClient {
+	return &HTTPClient{
+		context: ctx,
+	}
+}
+
+// func (c *HTTPClient)
--- a/pkg/client/tcp.go
+++ b/pkg/client/tcp.go
@ -1,10 +0,0 @@
-//           ___   ____               ___       ___
-// \ \  / / | _   |  __| \ \  / / || | __  || || _ |
-//  \ \/ /  |___  | |__   \ \/ /  || |___  || ||___|
-//   \  /   | _   | _  |   \  /   ||  __ | || ||\\
-//    \/    |___  |___ |    \/    || ____| || || \\
-
-// Copyright (c) 2021 Piotr Biernat. https://pbiernat.dev. MIT License
-// Repo: https://git.pbiernat.dev/golang/vegvisir
-
-package client
--- a/pkg/config/config.go
+++ b/pkg/config/config.go
@ -15,6 +15,7 @@ import (
 	"os"
 )

+// Config struct
 type Config struct {
 	Server   Server
 	Cache    Cache
@ -23,11 +24,13 @@ type Config struct {
 	confPath string
 }

+// Server struct
 type Server struct {
 	Address string
 	Port    int
 }

+// Cache struct
 type Cache struct {
 	Type        string
 	Host        string
@ -35,33 +38,38 @@ type Cache struct {
 	Username    string
 	Password    string
 	Database    string
-	RouteTtl    int
-	ResponseTtl int
+	RouteTTL    int
+	ResponseTTL int
 }

+// Backend struct
 type Backend struct {
-	PrefixUrl      string
+	PrefixURL      string
 	BackendAddress string
 	Protocol       string
 	Routes         []Route
 }

+// Route struct
 type Route struct {
 	Pattern string
 	Target  string
 }

+// DefaultRoute shorthand
 var DefaultRoute = Route{
 	Pattern: "(.*)",
 	Target:  "",
 }

+// New function
 func New(confPath string) *Config {
 	return &Config{
 		confPath: confPath,
 	}
 }

+// Load function
 func (c *Config) Load() error {
 	if _, err := os.Stat(c.confPath); err != nil {
 		return err
--- a/pkg/server/response.go
+++ b/pkg/server/response.go
@ -1,10 +0,0 @@
-//           ___   ____               ___       ___
-// \ \  / / | _   |  __| \ \  / / || | __  || || _ |
-//  \ \/ /  |___  | |__   \ \/ /  || |___  || ||___|
-//   \  /   | _   | _  |   \  /   ||  __ | || ||\\
-//    \/    |___  |___ |    \/    || ____| || || \\
-//
-// Copyright (c) 2021 Piotr Biernat. https://pbiernat.dev. MIT License
-// Repo: https://git.pbiernat.dev/golang/vegvisir
-
-package server
--- a/pkg/server/router.go
+++ b/pkg/server/router.go
@ -17,18 +17,21 @@ import (
 	"vegvisir/pkg/config"
 )

+// Router struct
 type Router struct {
 	config *config.Config
 	rcm    cache.RouteCacheManager     // Redis cache
 	rCache map[string]cache.RouteCache // Internal route cache - TMP?
 }

+// Route struct
 type Route struct {
-	SourceUrl string
-	TargetUrl string
+	SourceURL string
+	TargetURL string
 }

-func NewRouter(conf *config.Config, cacheDS cache.CacheDatastore, ttl int) *Router {
+// NewRouter function
+func NewRouter(conf *config.Config, cacheDS cache.Datastore, ttl int) *Router {
 	return &Router{
 		config: conf,
 		rcm:    cache.NewRouteCacheManager(cacheDS, ttl),
@ -36,42 +39,43 @@ func NewRouter(conf *config.Config, cacheDS cache.CacheDatastore, ttl int) *Rout
 	}
 }

+// FindByRequestURL function
 func (r *Router) FindByRequestURL(url []byte) (bool, Route) {
-	var sUrl string = string(url)
+	var sURL string = string(url)

-	for bId := range r.config.Backends {
-		bck := r.config.Backends[bId]
-		if !strings.Contains(sUrl, bck.PrefixUrl) {
+	for bID := range r.config.Backends {
+		bck := r.config.Backends[bID]
+		if !strings.Contains(sURL, bck.PrefixURL) {
 			continue
 		}

-		for rId := range bck.Routes {
-			routeCfg := &bck.Routes[rId]
+		for rID := range bck.Routes {
+			routeCfg := &bck.Routes[rID]

 			// if ok, cRoute := s.rCacheManager.Load(sUri); ok {
 			// 	return true, cRoute
 			// }
-			if cRoute, ok := r.rCache[sUrl]; ok {
+			if cRoute, ok := r.rCache[sURL]; ok {
 				route := Route{
-					SourceUrl: cRoute.SourceUrl,
-					TargetUrl: cRoute.TargetUrl,
+					SourceURL: cRoute.SourceURL,
+					TargetURL: cRoute.TargetURL,
 				}
 				return true, route
 			}

-			rgxp := regexp.MustCompile(fmt.Sprintf("%s%s", bck.PrefixUrl, routeCfg.Pattern))
+			rgxp := regexp.MustCompile(fmt.Sprintf("%s%s", bck.PrefixURL, routeCfg.Pattern))
 			if rgxp.Match(url) {
-				targetUrl := bck.BackendAddress + rgxp.ReplaceAllString(sUrl, routeCfg.Target)
+				targetURL := bck.BackendAddress + rgxp.ReplaceAllString(sURL, routeCfg.Target)

-				route := Route{
-					SourceUrl: sUrl,
-					TargetUrl: targetUrl,
+				route := Route{ // FIXME: duplicated #1
+					SourceURL: sURL,
+					TargetURL: targetURL,
 				}

 				// s.rCacheManager.Save(sUri, cRoute)
-				r.rCache[sUrl] = cache.RouteCache{
-					SourceUrl: route.SourceUrl,
-					TargetUrl: route.TargetUrl,
+				r.rCache[sURL] = cache.RouteCache{ // FIXME: duplicated #1
+					SourceURL: route.SourceURL,
+					TargetURL: route.TargetURL,
 				}

 				return true, route
--- a/pkg/server/server.go
+++ b/pkg/server/server.go
@ -15,6 +15,7 @@ import (
 	"log"
 	"os"
 	"os/signal"
+	"syscall"
 	"time"
 	"vegvisir/pkg/cache"
 	"vegvisir/pkg/config"
@ -23,16 +24,20 @@ import (
 )

 const (
+	// ServerVersion static
 	ServerVersion = "0.1-dev"
+	// ServerName static
 	ServerName = "Vegvisir/" + ServerVersion
 )

+// Server struct
 type Server struct {
 	config *config.Config
 	router *Router
 	respCM cache.ResponseCacheManager // Redis response cache
 }

+// NewServer function
 func NewServer(cPath string) *Server {
 	config := config.New(cPath)

@ -44,11 +49,12 @@ func NewServer(cPath string) *Server {

 	return &Server{
 		config: config,
-		router: NewRouter(config, *datastore, config.Cache.RouteTtl),
-		respCM: cache.NewResponseCacheManager(*datastore, config.Cache.ResponseTtl),
+		router: NewRouter(config, *datastore, config.Cache.RouteTTL),
+		respCM: cache.NewResponseCacheManager(*datastore, config.Cache.ResponseTTL),
 	}
 }

+// Run function
 func (s *Server) Run() {
 	go func() {
 		serverAddress := s.config.Server.Address + ":" + fmt.Sprint(s.config.Server.Port)
@ -61,7 +67,7 @@ func (s *Server) Run() {

 	// Wait for an interrupt
 	interrupt := make(chan os.Signal, 1)
-	signal.Notify(interrupt, os.Interrupt, os.Kill)
+	signal.Notify(interrupt, os.Interrupt, syscall.SIGTERM)
 	<-interrupt

 	log.Println("SIGKILL or SIGINT caught, shutting down...")
@ -74,27 +80,29 @@ func (s *Server) Run() {
 	log.Println("Server shutdown successfully.")
 }

+// Shutdown function
 func (s *Server) Shutdown(ctx context.Context) { // TODO: wait for all connections to finish
-	log.Println("Shuting down finished")
+	log.Println("Shuting down...")
 }

 func (s *Server) mainHandler(ctx *fasthttp.RequestCtx) {
 	// http := client.NewHttpClient(ctx)

 	// move all below logic to concrete handler or sth....
-	reqUrl, sReqUrl, sReqMethod := ctx.RequestURI(), string(ctx.RequestURI()), string(ctx.Method())
-	log.Println("Incoming request:", sReqMethod, sReqUrl)
+	reqURL, sReqURL, sReqMethod := ctx.RequestURI(), string(ctx.RequestURI()), string(ctx.Method())
+	// log.Println("Incoming request:", sReqMethod, sReqURL)

-	found, route := s.router.FindByRequestURL(reqUrl)
+	found, route := s.router.FindByRequestURL(reqURL)
 	if !found {
 		// FIXME: return 404/5xx error in repsonse, maybe define it in Backend config?
 		ctx.SetStatusCode(fasthttp.StatusNotFound)
 		return
 	}

-	// handle response caching
-	if ok, data := s.respCM.Load(sReqUrl); ok {
-		log.Println("Read resp from cache: ", route.TargetUrl)
+	go func() {
+		cacheFound, data := s.respCM.Load(sReqURL)
+		if cacheFound { // get response from cache
+			// log.Println("Read resp from cache: ", route.TargetUrl)

 			// copy headers and body from cache
 			ctx.Response.Header.DisableNormalizing()
@ -102,8 +110,8 @@ func (s *Server) mainHandler(ctx *fasthttp.RequestCtx) {
 				ctx.Response.Header.Set(key, value)
 			}
 			ctx.SetBody([]byte(data.Body))
-	} else {
-		log.Println("Send req to backend url: ", route.TargetUrl)
+		} else { // send request to backend and save to cache
+			log.Println("Send req to backend url: ", route.TargetURL)

 			// prepare to send request to backend - separate
 			bckReq := fasthttp.AcquireRequest()
@ -112,7 +120,7 @@ func (s *Server) mainHandler(ctx *fasthttp.RequestCtx) {
 			defer fasthttp.ReleaseResponse(bckResp)

 			// copy headers from backend response and prepare request for backend - separate
-		bckReq.SetRequestURI(route.TargetUrl)
+			bckReq.SetRequestURI(route.TargetURL)
 			bckReq.Header.SetMethod(sReqMethod)

 			err := fasthttp.Do(bckReq, bckResp)
@ -135,10 +143,11 @@ func (s *Server) mainHandler(ctx *fasthttp.RequestCtx) {

 			// save response to cache
 			respCache := cache.ResponseCache{
-			URL:     sReqUrl,
+				URL:     sReqURL,
 				Body:    string(bckResp.Body()),
 				Headers: headers,
 			} // FIXME: prepare resp cache struct in respCM.Save method or other service...
-		s.respCM.Save(sReqUrl, respCache)
+			s.respCM.Save(sReqURL, respCache)
 		}
+	}()
 }
--- a/pkg/server/struct.go
+++ b/pkg/server/struct.go
@ -1,10 +0,0 @@
-//           ___   ____               ___       ___
-// \ \  / / | _   |  __| \ \  / / || | __  || || _ |
-//  \ \/ /  |___  | |__   \ \/ /  || |___  || ||___|
-//   \  /   | _   | _  |   \  /   ||  __ | || ||\\
-//    \/    |___  |___ |    \/    || ____| || || \\
-//
-// Copyright (c) 2021 Piotr Biernat. https://pbiernat.dev. MIT License
-// Repo: https://git.pbiernat.dev/golang/vegvisir
-
-package server
--- a/vegvisir.json
+++ b/vegvisir.json
@ -5,7 +5,7 @@
    },
    "backends": {
        "news-app": {
-            "prefixUrl": "news/",
+            "prefixURL": "news/",
            "backendAddress": "http://172.17.0.1:3030",
            "routes": [{
                "pattern": "new/(.*)/([0-9]*)",
@ -19,7 +19,7 @@
            }]
        },
        "article-app": {
-            "prefixUrl": "art/",
+            "prefixURL": "art/",
            "backendAddress": "http://172.17.0.1:3030",
            "routes": [{
                "pattern": "art1/(.*)",
@ -31,9 +31,13 @@
        }
    },
    "cache": {
-        "ttl": 300,
-        "route_ttl": 300,
-        "response_ttl": 300,
-        "headers_ttl": 300
+        "type": "redis",
+        "host": "localhost",
+        "port": 6379,
+        "username": "",
+        "password": "",
+        "database": "0",
+        "routeTTL": 10,
+        "responseTTL": 10
    }
 }
--- a/vegvisir.json.dist
+++ b/vegvisir.json.dist
@ -5,7 +5,7 @@
    },
    "backends": {
        "news-app": {
-            "prefixUrl": "news/",
+            "prefixURL": "news/",
            "backendAddress": "http://127.0.0.1:3030",
            "routes": [{
                "pattern": "new/(.*)",
@ -19,7 +19,7 @@
            }]
        },
        "article-app": {
-            "prefixUrl": "art/",
+            "prefixURL": "art/",
            "backendAddress": "http://127.0.0.1:3030",
            "routes": [{
                "pattern": "art1/(.*)",
@ -37,7 +37,7 @@
        "username": "",
        "password": "",
        "database": "0",
-        "routeTtl": 300,
-        "responseTtl": 300
+        "routeTTL": 300,
+        "responseTTL": 300
    }
 }
Author	SHA1	Message	Date
Piotr Biernat	4f10933caa	Merge branch 'develop' All checks were successful continuous-integration/drone/push Build is passing Details	2021-11-08 00:57:56 +01:00
Piotr Biernat	b0e492c163	Fixes after code linters suggestions All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details	2021-08-03 00:13:14 +02:00
Piotr Biernat	e070fc402a	Added go vet, staticheck and lint to .drone.yml Some checks failed continuous-integration/drone/push Build is failing Details	2021-08-02 23:44:25 +02:00
keedosn	268cab5f79	Merge pull request 'develop-issue-4' (#8 ) from develop-issue-4 into develop All checks were successful continuous-integration/drone/push Build is passing Details Reviewed-on: https://git.pbiernat.dev/golang/vegvisir/pulls/8	2021-07-25 20:10:28 +01:00
Piotr Biernat	445a205550	Merge branch 'develop' into master All checks were successful continuous-integration/drone/push Build is passing Details	2021-07-23 17:01:05 +02:00