code quality fixes

.drone.yml

@@ -7,7 +7,7 @@ steps:
   image: golang:latest
   commands:
   - go install honnef.co/go/tools/cmd/staticcheck@latest
-  - staticcheck ./src/internal/...
+  - cd src && staticcheck ./...
   volumes:
   - name: gopath
     path: /go
@@ -16,7 +16,7 @@ steps:
   image: golang:latest
   commands:
   - go install golang.org/x/lint/golint@latest
-  - golint ./src/internal/...
+  - golint ./src/...
   volumes:
   - name: gopath
     path: /go
@@ -24,7 +24,7 @@ steps:
 - name: analyze
   image: golang:latest
   commands:
-  - go vet ./src/internal/...
+  - cd src && go vet ./...
   volumes:
   - name: gopath
     path: /go

Dockerfile

@@ -14,6 +14,7 @@ RUN go mod download && \
 FROM gcr.io/distroless/base-debian10
 
 LABEL author="Piotr Biernat"
+LABEL service="identity"
 LABEL vendor="Egommerce"
 LABEL version="1.0"
 

src/cmd/main.go

@@ -14,9 +14,9 @@ import (
 )
 
 const (
-	defHttpIp   = "0.0.0.0"
+	defHTTPIP   = "0.0.0.0"
-	defHttpPort = "8080"
+	defHTTPPort = "8080"
-	defDbUrl    = "postgres://postgres:12345678@postgres_svc:5432/egommerce"
+	defDbURL    = "postgres://postgres:12345678@postgres_svc:5432/egommerce"
 )
 
 func main() {
@@ -24,15 +24,15 @@ func main() {
 		app.Panicf("Error loading .env file")
 	}
 
-	httpAddr := net.JoinHostPort(config.GetEnv("SERVER_IP", defHttpIp), defHttpPort)
+	httpAddr := net.JoinHostPort(config.GetEnv("SERVER_IP", defHTTPIP), defHTTPPort)
-	dbConnStr := config.GetEnv("DATABASE_URL", defDbUrl)
+	dbConnStr := config.GetEnv("DATABASE_URL", defDbURL)
 
 	dbc, err := database.Connect(dbConnStr)
 	if err != nil {
 		app.Panicf("Unable to connect to database: %v\n", err)
 	}
 
-	env := &handler.Env{httpAddr, dbc}
+	env := &handler.Env{Addr: httpAddr, DB: dbc}
 	srv := app.NewServer(env)
 
 	go srv.Start()

src/internal/app/handler/handler.go

@@ -3,7 +3,7 @@ package handler
 import (
 	"bytes"
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"log"
 	"net/http"
 
@@ -55,9 +55,9 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 }
 
 func decodeRequestData(r *http.Request, v interface{}) error {
-	buf, _ := ioutil.ReadAll(r.Body)
+	buf, _ := io.ReadAll(r.Body)
-	rdr := ioutil.NopCloser(bytes.NewReader(buf))
+	rdr := io.NopCloser(bytes.NewReader(buf))
-	r.Body = ioutil.NopCloser(bytes.NewReader(buf))
+	r.Body = io.NopCloser(bytes.NewReader(buf))
 
 	json.NewDecoder(rdr).Decode(&v)
 

src/internal/app/server.go

@@ -3,7 +3,7 @@ package app
 import (
 	"bytes"
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"log"
 	"net"
 	"net/http"
@@ -63,8 +63,8 @@ func PrepareHeadersMiddleware(next http.Handler) http.Handler {
 
 func ValidateJsonBodyMiddleware(next http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		buf, _ := ioutil.ReadAll(r.Body)
+		buf, _ := io.ReadAll(r.Body)
-		r.Body = ioutil.NopCloser(bytes.NewReader(buf)) // rollack *Request to original state
+		r.Body = io.NopCloser(bytes.NewReader(buf)) // rollack *Request to original state
 
 		if len(buf) > 0 && !json.Valid(buf) {
 			w.WriteHeader(http.StatusBadRequest)